Return-Path: X-Original-To: apmail-hadoop-hdfs-commits-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC66BC59C for ; Fri, 4 May 2012 20:16:47 +0000 (UTC) Received: (qmail 68538 invoked by uid 500); 4 May 2012 20:16:47 -0000 Delivered-To: apmail-hadoop-hdfs-commits-archive@hadoop.apache.org Received: (qmail 68506 invoked by uid 500); 4 May 2012 20:16:47 -0000 Mailing-List: contact hdfs-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-commits@hadoop.apache.org Received: (qmail 68496 invoked by uid 99); 4 May 2012 20:16:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 20:16:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 20:16:44 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 05C542388847; Fri, 4 May 2012 20:16:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1334156 - in /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs: CHANGES.txt src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java Date: Fri, 04 May 2012 20:16:23 -0000 To: hdfs-commits@hadoop.apache.org From: szetszwo@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120504201624.05C542388847@eris.apache.org> Author: szetszwo Date: Fri May 4 20:16:23 2012 New Revision: 1334156 URL: http://svn.apache.org/viewvc?rev=1334156&view=rev Log: HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1334156&r1=1334155&r2=1334156&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original) +++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Fri May 4 20:16:23 2012 @@ -419,6 +419,9 @@ Release 2.0.0 - UNRELEASED HDFS-3339. Change INode to package private. (John George via szetszwo) + HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. + (Brandon Li via szetszwo) + OPTIMIZATIONS HDFS-3024. Improve performance of stringification in addStoredBlock (todd) Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java?rev=1334156&r1=1334155&r2=1334156&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java (original) +++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java Fri May 4 20:16:23 2012 @@ -17,22 +17,16 @@ */ package org.apache.hadoop.hdfs.server.protocol; -import java.io.DataInput; -import java.io.DataOutput; -import java.io.IOException; import java.util.Collections; import java.util.List; -import org.apache.hadoop.io.Writable; - import com.google.common.base.Joiner; import com.google.common.base.Preconditions; -import com.google.common.collect.Lists; /** * An enumeration of logs available on a remote NameNode. */ -public class RemoteEditLogManifest implements Writable { +public class RemoteEditLogManifest { private List logs; @@ -75,25 +69,4 @@ public class RemoteEditLogManifest imple public String toString() { return "[" + Joiner.on(", ").join(logs) + "]"; } - - - @Override - public void write(DataOutput out) throws IOException { - out.writeInt(logs.size()); - for (RemoteEditLog log : logs) { - log.write(out); - } - } - - @Override - public void readFields(DataInput in) throws IOException { - int numLogs = in.readInt(); - logs = Lists.newArrayList(); - for (int i = 0; i < numLogs; i++) { - RemoteEditLog log = new RemoteEditLog(); - log.readFields(in); - logs.add(log); - } - checkState(); - } }