Return-Path: X-Original-To: apmail-hadoop-hdfs-commits-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 618996718 for ; Wed, 18 May 2011 17:44:23 +0000 (UTC) Received: (qmail 50617 invoked by uid 500); 18 May 2011 17:44:23 -0000 Delivered-To: apmail-hadoop-hdfs-commits-archive@hadoop.apache.org Received: (qmail 50580 invoked by uid 500); 18 May 2011 17:44:22 -0000 Mailing-List: contact hdfs-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-commits@hadoop.apache.org Received: (qmail 50572 invoked by uid 99); 18 May 2011 17:44:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 May 2011 17:44:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 May 2011 17:44:20 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 19B2923889F7; Wed, 18 May 2011 17:43:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1124349 - in /hadoop/hdfs/trunk: CHANGES.txt src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Date: Wed, 18 May 2011 17:43:59 -0000 To: hdfs-commits@hadoop.apache.org From: szetszwo@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110518174359.19B2923889F7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: szetszwo Date: Wed May 18 17:43:58 2011 New Revision: 1124349 URL: http://svn.apache.org/viewvc?rev=1124349&view=rev Log: HDFS-1927. Fix a bug which causes ip=null in NameNode audit log. Contributed by John George Modified: hadoop/hdfs/trunk/CHANGES.txt hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Modified: hadoop/hdfs/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/CHANGES.txt?rev=1124349&r1=1124348&r2=1124349&view=diff ============================================================================== --- hadoop/hdfs/trunk/CHANGES.txt (original) +++ hadoop/hdfs/trunk/CHANGES.txt Wed May 18 17:43:58 2011 @@ -593,6 +593,9 @@ Trunk (unreleased changes) HDFS-1881. Federation: after taking snapshot the current directory of datanode is empty. (Tanping Wang via suresh) + HDFS-1927. Fix a bug which causes ip=null in NameNode audit log. + (John George via szetszwo) + Release 0.22.0 - Unreleased INCOMPATIBLE CHANGES Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?rev=1124349&r1=1124348&r2=1124349&view=diff ============================================================================== --- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (original) +++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Wed May 18 17:43:58 2011 @@ -5415,12 +5415,11 @@ public class FSNamesystem implements FSC } /** - * If the remote IP for namenode method invokation is null, then the - * invocation is internal to the namenode. Client invoked methods are invoked - * over RPC and always have address != null. + * Client invoked methods are invoked over RPC and will be in + * RPC call context even if the client exits. */ private boolean isExternalInvocation() { - return Server.getRemoteIp() != null; + return Server.isRpcInvocation(); } /**