hadoop-hdfs-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szets...@apache.org
Subject svn commit: r1124349 - in /hadoop/hdfs/trunk: CHANGES.txt src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
Date Wed, 18 May 2011 17:43:59 GMT
Author: szetszwo
Date: Wed May 18 17:43:58 2011
New Revision: 1124349

URL: http://svn.apache.org/viewvc?rev=1124349&view=rev
Log:
HDFS-1927. Fix a bug which causes ip=null in NameNode audit log.  Contributed by John George

Modified:
    hadoop/hdfs/trunk/CHANGES.txt
    hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

Modified: hadoop/hdfs/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/CHANGES.txt?rev=1124349&r1=1124348&r2=1124349&view=diff
==============================================================================
--- hadoop/hdfs/trunk/CHANGES.txt (original)
+++ hadoop/hdfs/trunk/CHANGES.txt Wed May 18 17:43:58 2011
@@ -593,6 +593,9 @@ Trunk (unreleased changes)
     HDFS-1881. Federation: after taking snapshot the current directory 
     of datanode is empty. (Tanping Wang via suresh)
 
+    HDFS-1927. Fix a bug which causes ip=null in NameNode audit log.
+    (John George via szetszwo)
+
 Release 0.22.0 - Unreleased
 
   INCOMPATIBLE CHANGES

Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?rev=1124349&r1=1124348&r2=1124349&view=diff
==============================================================================
--- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (original)
+++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Wed
May 18 17:43:58 2011
@@ -5415,12 +5415,11 @@ public class FSNamesystem implements FSC
   }
   
   /**
-   * If the remote IP for namenode method invokation is null, then the
-   * invocation is internal to the namenode. Client invoked methods are invoked
-   * over RPC and always have address != null.
+   * Client invoked methods are invoked over RPC and will be in 
+   * RPC call context even if the client exits.
    */
   private boolean isExternalInvocation() {
-    return Server.getRemoteIp() != null;
+    return Server.isRpcInvocation();
   }
   
   /**



Mime
View raw message