Author: todd
Date: Sun May 8 23:57:31 2011
New Revision: 1100841
URL: http://svn.apache.org/viewvc?rev=1100841&view=rev
Log:
Address minor review feedback from eli on HDFS-1793.
Modified:
hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImageTransactionalStorageInspector.java
Modified: hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
URL: http://svn.apache.org/viewvc/hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java?rev=1100841&r1=1100840&r2=1100841&view=diff
==============================================================================
--- hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
(original)
+++ hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
Sun May 8 23:57:31 2011
@@ -526,7 +526,7 @@ public class FSImage implements NNStorag
it.hasNext();) {
StorageDirectory sd = it.next();
if (!sd.getVersionFile().exists()) {
- LOG.info("Storage directory " + sd + " contains no VERSION file. Skipping...");
+ LOG.warn("Storage directory " + sd + " contains no VERSION file. Skipping...");
continue;
}
sd.read(); // sets layoutVersion
Modified: hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImageTransactionalStorageInspector.java
URL: http://svn.apache.org/viewvc/hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImageTransactionalStorageInspector.java?rev=1100841&r1=1100840&r2=1100841&view=diff
==============================================================================
--- hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImageTransactionalStorageInspector.java
(original)
+++ hadoop/hdfs/branches/HDFS-1073/src/java/org/apache/hadoop/hdfs/server/namenode/FSImageTransactionalStorageInspector.java
Sun May 8 23:57:31 2011
@@ -159,8 +159,6 @@ class FSImageTransactionalStorageInspect
* the storage directory that was inspected first will be preferred.
*
* Returns null if no images were found.
- *
- * TODO this is only used by unit tests I think?
*/
FoundFSImage getLatestImage() {
FoundFSImage ret = null;
@@ -394,6 +392,7 @@ class FSImageTransactionalStorageInspect
}
}
}
+
/**
* Record of an image that has been located and had its filename parsed.
*/
|