Return-Path: Delivered-To: apmail-hadoop-hdfs-commits-archive@minotaur.apache.org Received: (qmail 60106 invoked from network); 30 Apr 2010 22:27:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Apr 2010 22:27:49 -0000 Received: (qmail 16374 invoked by uid 500); 30 Apr 2010 22:27:49 -0000 Delivered-To: apmail-hadoop-hdfs-commits-archive@hadoop.apache.org Received: (qmail 16353 invoked by uid 500); 30 Apr 2010 22:27:49 -0000 Mailing-List: contact hdfs-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-dev@hadoop.apache.org Delivered-To: mailing list hdfs-commits@hadoop.apache.org Received: (qmail 16345 invoked by uid 99); 30 Apr 2010 22:27:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Apr 2010 22:27:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Apr 2010 22:27:46 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id BE9CD23889DE; Fri, 30 Apr 2010 22:26:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: svn commit: r939851 - in /hadoop/hdfs/trunk: ./ src/java/ src/java/org/apache/hadoop/hdfs/ src/java/org/apache/hadoop/hdfs/server/datanode/ src/java/org/apache/hadoop/hdfs/server/namenode/ Date: Fri, 30 Apr 2010 22:26:55 -0000 To: hdfs-commits@hadoop.apache.org From: shv@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100430222655.BE9CD23889DE@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: shv Date: Fri Apr 30 22:26:55 2010 New Revision: 939851 URL: http://svn.apache.org/viewvc?rev=939851&view=rev Log: HDFS-1107. Turn on append by default. Contributed by Konstantin Shvachko. Modified: hadoop/hdfs/trunk/CHANGES.txt hadoop/hdfs/trunk/src/java/hdfs-default.xml hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Modified: hadoop/hdfs/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/CHANGES.txt?rev=939851&r1=939850&r2=939851&view=diff ============================================================================== --- hadoop/hdfs/trunk/CHANGES.txt (original) +++ hadoop/hdfs/trunk/CHANGES.txt Fri Apr 30 22:26:55 2010 @@ -307,7 +307,7 @@ Trunk (unreleased changes) HDFS-1101. TestDiskError.testLocalDirs() fails. (cdouglas via jghoman) HDFS-1031. Enhance the webUi to list a few of the corrupted files in HDFS. - (André Orian via dhruba) + (Andre Orian via dhruba) HDFS-1078. Create static and dynamic versions of libhdfs. (Sam Rash via dhruba) @@ -651,6 +651,8 @@ Release 0.21.0 - Unreleased HDFS-1067. Create block recovery tests that handle errors. (hairong) + HDFS-1107. Turn on append by default. (shv) + BUG FIXES HDFS-76. Better error message to users when commands fail because of Modified: hadoop/hdfs/trunk/src/java/hdfs-default.xml URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/hdfs-default.xml?rev=939851&r1=939850&r2=939851&view=diff ============================================================================== --- hadoop/hdfs/trunk/src/java/hdfs-default.xml (original) +++ hadoop/hdfs/trunk/src/java/hdfs-default.xml Fri Apr 30 22:26:55 2010 @@ -417,15 +417,6 @@ creations/deletions), or "all". - dfs.support.append - false - Does HDFS allow appends to files? - This is currently set to false because there are bugs in the - "append code" and is not supported in any prodction cluster. - - - - dfs.datanode.plugins Comma-separated list of datanode plug-ins to be activated. Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSConfigKeys.java URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSConfigKeys.java?rev=939851&r1=939850&r2=939851&view=diff ============================================================================== --- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (original) +++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSConfigKeys.java Fri Apr 30 22:26:55 2010 @@ -163,7 +163,7 @@ public class DFSConfigKeys extends Commo public static final String DFS_NAMENODE_HANDLER_COUNT_KEY = "dfs.namenode.handler.count"; public static final int DFS_NAMENODE_HANDLER_COUNT_DEFAULT = 10; public static final String DFS_SUPPORT_APPEND_KEY = "dfs.support.append"; - public static final boolean DFS_SUPPORT_APPEND_DEFAULT = false; + public static final boolean DFS_SUPPORT_APPEND_DEFAULT = true; public static final String DFS_HTTPS_ENABLE_KEY = "dfs.https.enable"; public static final boolean DFS_HTTPS_ENABLE_DEFAULT = false; public static final String DFS_DEFAULT_CHUNK_VIEW_SIZE_KEY = "dfs.default.chunk.view.size"; Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java?rev=939851&r1=939850&r2=939851&view=diff ============================================================================== --- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java (original) +++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java Fri Apr 30 22:26:55 2010 @@ -42,6 +42,7 @@ import org.apache.hadoop.conf.Configurat import org.apache.hadoop.fs.DF; import org.apache.hadoop.fs.DU; import org.apache.hadoop.fs.FileUtil; +import org.apache.hadoop.hdfs.DFSConfigKeys; import org.apache.hadoop.hdfs.protocol.Block; import org.apache.hadoop.hdfs.protocol.BlockListAsLongs; import org.apache.hadoop.hdfs.protocol.DatanodeInfo; @@ -839,14 +840,15 @@ public class FSDataset implements FSCons // Used for synchronizing access to usage stats private Object statsLock = new Object(); - boolean supportAppends = false; + boolean supportAppends = true; /** * An FSDataset has a directory where it loads its data files. */ public FSDataset(DataStorage storage, Configuration conf) throws IOException { this.maxBlocksPerDir = conf.getInt("dfs.datanode.numblocks", 64); - this.supportAppends = conf.getBoolean("dfs.support.append", false); + this.supportAppends = conf.getBoolean(DFSConfigKeys.DFS_SUPPORT_APPEND_KEY, + DFSConfigKeys.DFS_SUPPORT_APPEND_DEFAULT); FSVolume[] volArray = new FSVolume[storage.getNumStorageDirs()]; for (int idx = 0; idx < storage.getNumStorageDirs(); idx++) { volArray[idx] = new FSVolume(storage.getStorageDir(idx).getCurrentDir(), conf); Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?rev=939851&r1=939850&r2=939851&view=diff ============================================================================== --- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (original) +++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Fri Apr 30 22:26:55 2010 @@ -450,7 +450,8 @@ public class FSNamesystem implements FSC this.blockInvalidateLimit = Math.max(this.blockInvalidateLimit, 20*(int)(heartbeatInterval/1000)); this.accessTimePrecision = conf.getLong(DFSConfigKeys.DFS_NAMENODE_ACCESSTIME_PRECISION_KEY, 0); - this.supportAppends = conf.getBoolean("dfs.support.append", false); + this.supportAppends = conf.getBoolean(DFSConfigKeys.DFS_SUPPORT_APPEND_KEY, + DFSConfigKeys.DFS_SUPPORT_APPEND_DEFAULT); this.isAccessTokenEnabled = conf.getBoolean( DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_ENABLE_KEY, DFSConfigKeys.DFS_BLOCK_ACCESS_TOKEN_ENABLE_DEFAULT);