hadoop-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Wang <andrew.w...@cloudera.com>
Subject Re: Patch review process
Date Mon, 26 Jan 2015 19:55:22 GMT
Let's move this over to common-dev@, general@ is normally used for project
announcements rather than discussion topics.

I'd like to summarize a few things mentioned on the private@ thread,
related to streamlining the code submission process.

- Gerrit was brought up again, as it has in the past, as something that
could make the actual process of reviewing and committing a lot easier.
This would be especially helpful for small patches, where the mechanics of
committing can take longer than reviewing the patch.
- There were also concerns about forking discussions between JIRA and
Gerrit. This has been an issue in Spark, and we'd like to keep discussions
and issue tracking centralized.

- Some talk about how to improve precommit. Right now it takes hours to run
the unit tests, which slows down patch iterations. One solution is running
tests in parallel (and even distributed). Previous distributed experiments
have done a full unit test run in a couple minutes, but it'd be a fair
amount of work to actually make this production ready.
- Also mention of putting in place more linting and static analysis.
Automating this will save reviewer time.

Best,
Andrew

On Mon, Jan 26, 2015 at 9:16 AM, Ted Yu <yuzhihong@gmail.com> wrote:

> In some cases, contributor responded to review comments and attached
> patches addressing the comments.
>
> Later on, there was simply no response to the latest patch - even with
> follow-on ping.
>
> I wish this aspect can be improved.
>
> Cheers
>
> On Sun, Jan 25, 2015 at 6:03 PM, Tsz Wo (Nicholas), Sze <
> s29752-hadoopgeneral@yahoo.com.invalid> wrote:
>
> > Hi contributors,
> > I would like to (re)start a discussion regrading to our patch review
> > process.  A similar discussion has been happened in a the hadoop private
> > mailing list, which is inappropriate.
> > Here is the problem:The patch available queues become longer and longer.
> > It seems that we never can catch up.  There are patches sitting in the
> > queues for years.  How could we speed up?
> > Regrads,Tsz-Wo
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message