Return-Path: Delivered-To: apmail-hadoop-general-archive@minotaur.apache.org Received: (qmail 21850 invoked from network); 18 Dec 2010 04:32:22 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 18 Dec 2010 04:32:22 -0000 Received: (qmail 34656 invoked by uid 500); 18 Dec 2010 04:32:21 -0000 Delivered-To: apmail-hadoop-general-archive@hadoop.apache.org Received: (qmail 34500 invoked by uid 500); 18 Dec 2010 04:32:21 -0000 Mailing-List: contact general-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@hadoop.apache.org Delivered-To: mailing list general@hadoop.apache.org Received: (qmail 34492 invoked by uid 99); 18 Dec 2010 04:32:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Dec 2010 04:32:20 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [74.125.82.176] (HELO mail-wy0-f176.google.com) (74.125.82.176) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Dec 2010 04:32:15 +0000 Received: by wye20 with SMTP id 20so1395222wye.35 for ; Fri, 17 Dec 2010 20:31:54 -0800 (PST) Received: by 10.216.46.19 with SMTP id q19mr1707835web.0.1292646713422; Fri, 17 Dec 2010 20:31:53 -0800 (PST) MIME-Version: 1.0 Sender: cos@boudnik.org Received: by 10.216.59.13 with HTTP; Fri, 17 Dec 2010 20:31:33 -0800 (PST) In-Reply-To: References: <20101020195420.GG2075@tp> <53F363B9-E865-4E63-907A-7F341A246235@yahoo-inc.com> <4D646D78-621B-4C50-9420-6B5EC7F49B54@mac.com> <7B1CE23C-E15A-4BA5-8D96-62163A56E23C@mac.com> <4CE46119.2030509@yahoo-inc.com> <8617BECB-78B4-42B6-B592-D7FC1F8DA923@mac.com> <4CE47C88.5050203@yahoo-inc.com> <41FB0800-3703-49C1-8069-DEB74FFE6FAC@mac.com> From: Konstantin Boudnik Date: Fri, 17 Dec 2010 20:31:33 -0800 X-Google-Sender-Auth: JO3p-aEIzkBcdA3g4w6PwqxPyb4 Message-ID: Subject: Re: Patch testing To: general@hadoop.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks Jacob. I am wasted already but I can do it on Sun, I think, unless it is done earlier. -- =A0 Take care, Konstantin (Cos) Boudnik On Fri, Dec 17, 2010 at 19:41, Jakob Homan wrote: > Ok. =A0I'll get a patch out for 1511 tomorrow, unless someone wants to > whip one up tonight. > > > On Fri, Dec 17, 2010 at 7:22 PM, Nigel Daley wrote: >> I agree with Cos on fixing HDFS-1511 first. Once that is done I'll enabl= e hdfs patch testing. >> >> Cheers, >> Nige >> >> Sent from my iPhone4 >> >> On Dec 17, 2010, at 7:01 PM, Konstantin Boudnik wrote: >> >>> One more issue needs to be addressed before test-patch is turned on HDF= S is >>> =A0https://issues.apache.org/jira/browse/HDFS-1511 >>> -- >>> =A0 Take care, >>> Konstantin (Cos) Boudnik >>> >>> >>> >>> On Fri, Dec 17, 2010 at 16:17, Konstantin Boudnik wrot= e: >>>> Considering that because of these 4 faulty cases every patch will be >>>> -1'ed a patch author will still have to look at it and make a comment >>>> why this particular -1 isn't valid. Lesser work, perhaps, but messier >>>> IMO. I'm not blocking it - I just feel like there's a better way. >>>> >>>> -- >>>> =A0 Take care, >>>> Konstantin (Cos) Boudnik >>>> >>>> >>>> >>>> On Fri, Dec 17, 2010 at 15:55, Jakob Homan wrote: >>>>>> If HDFS is added to the test-patch queue right now we get >>>>>> nothing but dozens of -1'ed patches. >>>>> There aren't dozens of patches being submitted currently. =A0The -1 >>>>> isn't the important thing, it's the grunt work of actually running >>>>> (and waiting) for the tests, test-patch, etc. that Hudson does so tha= t >>>>> the developer doesn't have to. >>>>> >>>>> On Fri, Dec 17, 2010 at 3:48 PM, Dhruba Borthakur = wrote: >>>>>> +1, thanks for doing this. >>>>>> >>>>>> On Fri, Dec 17, 2010 at 3:19 PM, Jakob Homan wro= te: >>>>>> >>>>>>> So, with test-patch updated to show the failing tests, saving the >>>>>>> developers the need to go and verify that the failed tests are all >>>>>>> known, how do people feel about turning on test-patch again for HDF= S >>>>>>> and mapred? =A0I think it'll help prevent any more tests from enter= ing >>>>>>> the "yeah, we know" category. >>>>>>> >>>>>>> Thanks, >>>>>>> jg >>>>>>> >>>>>>> >>>>>>> On Wed, Nov 17, 2010 at 5:08 PM, Jakob Homan = wrote: >>>>>>>> True, each patch would get a -1 and the failing tests would need t= o be >>>>>>>> verified as those known bad (BTW, it would be great if Hudson coul= d list >>>>>>>> which tests failed in the message it posts to JIRA). =A0But that's= still >>>>>>> quite >>>>>>>> a bit less error-prone work than if the developer runs the tests a= nd >>>>>>>> test-patch themselves. =A0Also, with 22 being cut, there are a lot= of >>>>>>> patches >>>>>>>> up in the air and several developers are juggling multiple patches= . =A0The >>>>>>>> more automation we can have, even if it's not perfect, will decrea= se >>>>>>> errors >>>>>>>> we may make. >>>>>>>> -jg >>>>>>>> >>>>>>>> Nigel Daley wrote: >>>>>>>>> >>>>>>>>> On Nov 17, 2010, at 3:11 PM, Jakob Homan wrote: >>>>>>>>> >>>>>>>>>>> It's also ready to run on MapReduce and HDFS but we won't turn = it on >>>>>>>>>>> until these projects build and test cleanly. =A0Looks like both= these >>>>>>> projects >>>>>>>>>>> currently have test failures. >>>>>>>>>> >>>>>>>>>> Assuming the projects are compiling and building, is there a rea= son to >>>>>>>>>> not turn it on despite the test failures? Hudson is invaluable t= o >>>>>>> developers >>>>>>>>>> who then don't have to run the tests and test-patch themselves. = =A0We >>>>>>> didn't >>>>>>>>>> turn Hudson off when it was working previously and there were kn= own >>>>>>>>>> failures. =A0I think one of the reasons we have more failing tes= ts now is >>>>>>> the >>>>>>>>>> higher cost of doing Hudson's work (not a great excuse I know). = =A0This >>>>>>> is >>>>>>>>>> particularly true now because several of the failing tests invol= ve >>>>>>> tests >>>>>>>>>> timing out, making the whole testing regime even longer. >>>>>>>>> >>>>>>>>> Every single patch would get a -1 and need investigation. =A0Curr= ently, >>>>>>> that >>>>>>>>> would be about 83 investigations between MR and HDFS issues that = are in >>>>>>>>> patch available state. =A0Shouldn't we focus on getting these tes= ts fixed >>>>>>> or >>>>>>>>> removed/? =A0Also, I need to get MAPREDUCE-2172 fixed (applies to= HDFS as >>>>>>>>> well) before I turn this on. >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> Nige >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Connect to me at http://www.facebook.com/dhruba >>>>>> >>>>> >>>> >> >