hadoop-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eli Collins <...@cloudera.com>
Subject Re: Hadoop code reviews on ReviewBoard?
Date Thu, 04 Nov 2010 06:49:57 GMT
On Wed, Nov 3, 2010 at 11:15 PM, Konstantin Shvachko
<shv.hadoop@gmail.com> wrote:
>  > I think the idea is to have issue/design-level discussion on jira and
> code-level discussion on RB.
>
> This is exactly my question. Why do we need two places to have the same
> discussion?
> Even if the comments are automatically replicated in jira and/or vice versa.
> Why not choose one and stick with it?

For a lot of jiras issue level discussion (what's the problem? how
should we solve it?) is very different from code level discussion
(does this code do what we claim it should? Is it sufficient to be
checked in?).

Thanks,
Eli

>
> Thanks,
> --Konst
>
> On Wed, Nov 3, 2010 at 10:56 AM, Eli Collins <eli@cloudera.com> wrote:
>
>> Hey Cos,
>>
>> I think the setup used for Hive and HBase posts the RB comments to the
>> jira which makes it easier to follow.
>>
>> RB isn't a second system for tracking issues, jira isn't a code review
>> system, and RB isn't an issue tracker. I think the idea is to have
>> issue/design-level discussion on jira and code-level discussion on RB.
>>
>> Thanks,
>> Eli
>>
>> On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko
>> <shv.hadoop@gmail.com> wrote:
>> > It looks very hard to follow.
>> > I have really hard time matching jira and review board comments.
>> > Especially when they interleave.
>> > Why again do we need a second system for tracking issues?
>> > --Konstantin
>> >
>> > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <acm@yahoo-inc.com>
>> wrote:
>> >
>> >> +1
>> >>
>> >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote:
>> >>
>> >> I saw an ASF announcement that there's now a review board instance
>> >>> available, it will be nice if we can try it out.
>> >>>
>> >>>
>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
>> >>>
>> >>> I filed the following JIRA to see if we can use review board to review
>> >>> Hadoop JIRAS.
>> >>>
>> >>> https://issues.apache.org/jira/browse/INFRA-3108
>> >>>
>> >>> thanks,
>> >>> dhruba
>> >>>
>> >>
>> >>
>> >
>>
>

Mime
View raw message