From common-issues-return-204901-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Sep 2 18:21:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 06E5318065D for ; Wed, 2 Sep 2020 20:21:53 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 45A0545442 for ; Wed, 2 Sep 2020 18:21:52 +0000 (UTC) Received: (qmail 46227 invoked by uid 500); 2 Sep 2020 18:21:52 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 46215 invoked by uid 99); 2 Sep 2020 18:21:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2020 18:21:51 +0000 From: =?utf-8?q?GitBox?= To: common-issues@hadoop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhadoop=5D_sunchao_commented_on_a_change_in_pull_re?= =?utf-8?q?quest_=232240=3A_HADOOP-17165=2E_Implement_service-user_feature_i?= =?utf-8?q?n_DecayRPCScheduler=2E?= Message-ID: <159907091182.32230.5161299586501100008.asfpy@gitbox.apache.org> Date: Wed, 02 Sep 2020 18:21:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: sunchao commented on a change in pull request #2240: URL: https://github.com/apache/hadoop/pull/2240#discussion_r482275899 ########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java ########## @@ -483,6 +501,12 @@ private void recomputeScheduleCache() { for (Map.Entry> entry : callCosts.entrySet()) { Object id = entry.getKey(); + // The priority for service users is always 0 + if (isServiceUser((String)id)) { Review comment: @tasanuma curious why you choose to do it here and `cachedOrComputedPriorityLevel` instead of `getPriorityLevel` in the previous patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org