From common-issues-return-204799-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Sep 1 15:32:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 7007D180660 for ; Tue, 1 Sep 2020 17:32:31 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id AF6A945403 for ; Tue, 1 Sep 2020 15:32:30 +0000 (UTC) Received: (qmail 25694 invoked by uid 500); 1 Sep 2020 15:32:30 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 25682 invoked by uid 99); 1 Sep 2020 15:32:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2020 15:32:30 +0000 From: =?utf-8?q?GitBox?= To: common-issues@hadoop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhadoop=5D_leosunli_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=232265=3A_HDFS-15551=2E_Tiny_Improve_for_DeadNode_detecto?= =?utf-8?q?r?= Message-ID: <159897435023.32230.759273766848778423.asfpy@gitbox.apache.org> Date: Tue, 01 Sep 2020 15:32:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: leosunli commented on a change in pull request #2265: URL: https://github.com/apache/hadoop/pull/2265#discussion_r481234104 ########## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java ########## @@ -181,6 +181,8 @@ private boolean isPeriodicRefreshEnabled() { private byte[] oneByteBuf; // used for 'int read()' protected void addToLocalDeadNodes(DatanodeInfo dnInfo) { + DFSClient.LOG.debug("Add {} to local dead nodes, previously was {}", Review comment: 1、Is it necessary to add log in Local dead nodes? 2、if add debug log in DFSInputStream#addToLocalDeadNodes, do you need add log in DFSInputStream#removeFromLocalDeadNodes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org