hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed Hussein (Jira)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-17126) implement non-guava Precondition checkNotNull
Date Wed, 16 Sep 2020 17:47:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ahmed Hussein updated HADOOP-17126:
-----------------------------------
    Attachment: HADOOP-17126.002.patch

> implement non-guava Precondition checkNotNull
> ---------------------------------------------
>
>                 Key: HADOOP-17126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17126
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>         Attachments: HADOOP-17126.001.patch, HADOOP-17126.002.patch
>
>
> As part In order to replace Guava Preconditions, we need to implement our own versions
of the API.
>  This Jira is to create {{checkNotNull}} in a new package dubbed {{unguava}}.
>  +The plan is as follows+
>  * create a new {{package org.apache.hadoop.util.unguava;}}
>  * {{create class Validate}}
>  * implement  {{package org.apache.hadoop.util.unguava.Validate;}} with the following
interface
>  ** {{checkNotNull(final T obj)}}
>  ** {{checkNotNull(final T reference, final Object errorMessage)}}
>  ** {{checkNotNull(final T obj, final String message, final Object... values)}}
>  ** {{checkNotNull(final T obj,final Supplier<String> msgSupplier)}}
>  * {{guava.preconditions used String.lenientformat which suppressed exceptions caused
by string formatting of the exception message . So, in order to avoid changing the behavior,
the implementation catches Exceptions triggered by building the message (IllegalFormat, InsufficientArg,
NullPointer..etc)}}
>  * {{After merging the new class, we can replace guava.Preconditions.checkNotNull by {{unguava.Validate.checkNotNull}}}}
>  * We need the change to go into trunk, 3.1, 3.2, and 3.3
>  
> Similar Jiras will be created to implement checkState, checkArgument, checkIndex



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message