hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HADOOP-17125) Using snappy-java in SnappyCodec
Date Fri, 25 Sep 2020 13:46:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-17125?focusedWorklogId=491132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491132
]

ASF GitHub Bot logged work on HADOOP-17125:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Sep/20 13:45
            Start Date: 25/Sep/20 13:45
    Worklog Time Spent: 10m 
      Work Description: dbtsai commented on a change in pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#discussion_r494537597



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyCompressor.java
##########
@@ -291,9 +283,17 @@ public long getBytesWritten() {
   public void end() {
   }
 
-  private native static void initIDs();
-
-  private native int compressBytesDirect();
-
-  public native static String getLibraryName();
+  private int compressDirectBuf() throws IOException {
+    if (uncompressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `uncompressedDirectBuf` for reading
+      uncompressedDirectBuf.limit(uncompressedDirectBufLen).position(0);
+      int size = Snappy.compress((ByteBuffer) uncompressedDirectBuf,
+              (ByteBuffer) compressedDirectBuf);
+      uncompressedDirectBufLen = 0;
+      uncompressedDirectBuf.limit(directBufferSize).position(0);

Review comment:
       nit, `uncompressedDirectBuf.limit(uncompressedDirectBuf.capacity()).position(0);` for
safety.
   

##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
##########
@@ -432,7 +412,11 @@ public void assertCompression(String name, Compressor compressor,
               joiner.join(name, "byte arrays not equals error !!!"),
               originalRawData, decompressOut.toByteArray());
         } catch (Exception ex) {
-          fail(joiner.join(name, ex.getMessage()));
+          if (ex.getMessage() != null) {
+            fail(joiner.join(name, ex.getMessage()));
+          } else {
+            fail(joiner.join(name, ExceptionUtils.getStackTrace(ex)));

Review comment:
       Why is this change needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 491132)
    Time Spent: 17h 50m  (was: 17h 40m)

> Using snappy-java in SnappyCodec
> --------------------------------
>
>                 Key: HADOOP-17125
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17125
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: common
>    Affects Versions: 3.3.0
>            Reporter: DB Tsai
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 17h 50m
>  Remaining Estimate: 0h
>
> In Hadoop, we use native libs for snappy codec which has several disadvantages:
>  * It requires native *libhadoop* and *libsnappy* to be installed in system *LD_LIBRARY_PATH*,
and they have to be installed separately on each node of the clusters, container images, or
local test environments which adds huge complexities from deployment point of view. In some
environments, it requires compiling the natives from sources which is non-trivial. Also, this
approach is platform dependent; the binary may not work in different platform, so it requires
recompilation.
>  * It requires extra configuration of *java.library.path* to load the natives, and it
results higher application deployment and maintenance cost for users.
> Projects such as *Spark* and *Parquet* use [snappy-java|[https://github.com/xerial/snappy-java]]
which is JNI-based implementation. It contains native binaries for Linux, Mac, and IBM in
jar file, and it can automatically load the native binaries into JVM from jar without any
setup. If a native implementation can not be found for a platform, it can fallback to pure-java
implementation of snappy based on [aircompressor|[https://github.com/airlift/aircompressor/tree/master/src/main/java/io/airlift/compress/snappy]].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message