hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HADOOP-17028) ViewFS should initialize target filesystems lazily
Date Fri, 04 Sep 2020 09:18:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-17028?focusedWorklogId=479027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479027
]

ASF GitHub Bot logged work on HADOOP-17028:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Sep/20 09:17
            Start Date: 04/Sep/20 09:17
    Worklog Time Spent: 10m 
      Work Description: abhishekdas99 commented on a change in pull request #2260:
URL: https://github.com/apache/hadoop/pull/2260#discussion_r483495855



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
##########
@@ -284,7 +290,15 @@ boolean isInternalDir() {
       return false;
     }
 
-    public T getTargetFileSystem() {
+    public T getTargetFileSystem() throws IOException {

Review comment:
       Added javadoc. Also added synchronized block around apply call to make sure only one
thread is initializing the file system instance.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 479027)
    Time Spent: 1h 10m  (was: 1h)

> ViewFS should initialize target filesystems lazily
> --------------------------------------------------
>
>                 Key: HADOOP-17028
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17028
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: client-mounts, fs, viewfs
>    Affects Versions: 3.2.1
>            Reporter: Uma Maheswara Rao G
>            Assignee: Abhishek Das
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently viewFS initialize all configured target filesystems when viewfs#init itself.
> Some target file system initialization involve creating heavy objects and proxy connections.
Ex: DistributedFileSystem#initialize will create DFSClient object which will create proxy
connections to NN etc.
> For example: if ViewFS configured with 10 target fs with hdfs uri and 2 targets with
s3a.
> If one of the client only work with s3a target, But ViewFS will initialize all targets
irrespective of what clients interested to work with. That means, here client will create
10 DFS initializations and 2 s3a initializations. Its unnecessary to have DFS initialization
here. So, it will be a good idea to initialize the target fs only when first time usage call
come to particular target fs scheme. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message