hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HADOOP-17023) Tune listStatus() api of s3a.
Date Tue, 08 Sep 2020 12:09:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-17023?focusedWorklogId=480084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480084
]

ASF GitHub Bot logged work on HADOOP-17023:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Sep/20 12:08
            Start Date: 08/Sep/20 12:08
    Worklog Time Spent: 10m 
      Work Description: mukund-thakur commented on pull request #2257:
URL: https://github.com/apache/hadoop/pull/2257#issuecomment-688823862


   > checkstyle complaining with fixable issues
   > 
   > ```
   > ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Listing.java:370:
   Listing.FileStatusListingIterator filesItr = createFileStatusListingIterator(: Line is
longer than 80 characters (found 81). [LineLength]
   > ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:34:import
java.util.Arrays;:8: Unused import - java.util.Arrays. [UnusedImports]
   > ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:2672:
 private RemoteIterator<S3AFileStatus> innerListStatus(Path f) throws FileNotFoundException,:
Line is longer than 80 characters (found 93). [LineLength]
   > ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:2686:
   }:5: '}' at column 5 should be on the same line as the next part of a multi-block statement
(one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[RightCurly]
   > ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:45:import
org.apache.hadoop.fs.s3a.impl.TestPartialDeleteFailures;:8: Unused import - org.apache.hadoop.fs.s3a.impl.TestPartialDeleteFailures.
[UnusedImports]
   > ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestS3Guard.java:138:
   S3AFileStatus[] result = S3AUtils.iteratorToStatuses(resultItr, new HashSet<>());:
Line is longer than 80 characters (found 85). [LineLength]
   > ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestS3Guard.java:205:
   S3AFileStatus[] result = S3AUtils.iteratorToStatuses(resultItr, new HashSet<>());:
Line is longer than 80 characters (found 85). [LineLength]
   > ```
   
   Yes I am going to fix the checkstyle. How is the rest of code? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 480084)
    Time Spent: 1h 50m  (was: 1h 40m)

> Tune listStatus() api of s3a.
> -----------------------------
>
>                 Key: HADOOP-17023
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17023
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.2.1
>            Reporter: Mukund Thakur
>            Assignee: Mukund Thakur
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Similar optimisation which was done for listLocatedSttaus() https://issues.apache.org/jira/browse/HADOOP-16465 
can done for listStatus() api as well. 
> This is going to reduce the number of remote calls in case of directory listing.
>  
> CC [~stevel@apache.org] [~shwethags]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message