hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] steveloughran edited a comment on pull request #2323: HADOOP-16830. Add public IOStatistics API.
Date Fri, 25 Sep 2020 13:26:18 GMT

steveloughran edited a comment on pull request #2323:
URL: https://github.com/apache/hadoop/pull/2323#issuecomment-698303509


   findbugs
   ```
   module:hadoop-common-project/hadoop-common
   --
     | org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject method is synchronized
At IOStatisticsSnapshot.java: At IOStatisticsSnapshot.java:[lines 241-254]
   ```
   
   The synchronized was lifted from TreeMap writeObject. When I turn it off I'll be reasonably
confident that findbugs will start complaining about unsynchronized accesses to field. Let's
see. If it blows up then I'll just disable the check here
   
   checkstyles are on the uses of the now deprecated methods;
   
   
   ```
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java:[34,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[82,32]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[83,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[24,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java:[68,16]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:[436,51]
[deprecation] FAST_UPLOAD in Constants has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[829,13]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,6]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,25]
[deprecation] CallableRaisingIOE in FunctionsRaisingIOE has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[103,18]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[121,18]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestS3SelectMRJob.java:[33,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[48,32]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[49,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStoreScale.java:[52,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestS3SelectMRJob.java:[212,22]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[320,21]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[320,40]
[deprecation] CallableRaisingIOE in FunctionsRaisingIOE has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[324,16]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   [WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStoreScale.java:[535,13]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
   ```
   
   In the full s3a patch these are all migrated; in this PR I'm restricting all changes to
hadoop-common, so *will not fixe them in this patch*


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message