hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] klcopp commented on a change in pull request #2321: HADOOP-17267: Add debug-level logs in Filesystem#close
Date Fri, 25 Sep 2020 13:13:47 GMT

klcopp commented on a change in pull request #2321:
URL: https://github.com/apache/hadoop/pull/2321#discussion_r494099461



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
##########
@@ -636,18 +636,19 @@ public static void closeAll() throws IOException {
   public static void closeAllForUGI(UserGroupInformation ugi)
   throws IOException {
     if (LOGGER.isDebugEnabled()) {
-      debugLogFileSystemClose("closeAllForUGI", "UGI: " + ugi.toString());
+      debugLogFileSystemClose("closeAllForUGI", "UGI: " + ugi);
     }
     CACHE.closeAll(ugi);
   }
 
   private static void debugLogFileSystemClose(String methodName, String additionalInfo) {
     StackTraceElement callingMethod = new Throwable().fillInStackTrace().getStackTrace()[2];
-    LOGGER.debug(
-        "FileSystem." + methodName + "() called by method: "
-            + callingMethod.getClassName() + "." + callingMethod.getMethodName()
-            + "(" + callingMethod.getFileName() + ":" + callingMethod.getLineNumber() + ");
"
-            + (additionalInfo != null ? additionalInfo : ""));
+    LOGGER.debug("FileSystem.{}() called by method: {}.{}({}:{}); {}", methodName, callingMethod.getClassName(),

Review comment:
       I included the URI in the case of close().




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message