hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] goiri commented on a change in pull request #2284: HDFS-15561. Fix NullPointException when start dfsrouter
Date Tue, 08 Sep 2020 16:05:15 GMT

goiri commented on a change in pull request #2284:
URL: https://github.com/apache/hadoop/pull/2284#discussion_r485034706



##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java
##########
@@ -553,11 +553,18 @@ public void verifyToken(DelegationTokenIdentifier tokenId, byte[] password)
   protected NamenodeHeartbeatService createLocalNamenodeHeartbeatService() {
     // Detect NN running in this machine
     String nsId = DFSUtil.getNamenodeNameServiceId(conf);
+
+    if (nsId == null) {
+      LOG.error("Cannot find nameservice id for local {}", nsId);

Review comment:
       Can we add a test for this situation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message