hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] YaYun-Wang commented on a change in pull request #2189: HDFS-15025. Applying NVDIMM storage media to HDFS
Date Fri, 04 Sep 2020 10:01:55 GMT

YaYun-Wang commented on a change in pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#discussion_r477304478

File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
@@ -77,6 +77,9 @@
   /** Returns true if the volume is NOT backed by persistent storage. */
   boolean isTransientStorage();

Review comment:
       The "isTransientStorage" method is still available. 
   In the original code,` isTransient()` and `isTransientStorage` methods are used to determine
whether to support FsDatasetCache, Persistent, Quota, and Movable. 
   FsDatasetCache will be used When the storage type is persistent. NVDIMM is RAM to some
extent, which is fast. However, NVDIMM is a persistent storage type.  Then, `isTransient()`
and `isTransientStorage() ` used to determine whether to support FsDatasetCache can't meet
the requirements. Therefore, we add  `isRAM()` and `isRAMStorage() ` methods to decide whether
cache is supported or not. And the other functions, such as, Persistent,  Quota, and Movable
judged by`isTransient()` and `isTransientStorage() ` methods.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message