hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] abhishekdas99 commented on pull request #2260: HADOOP-17028. ViewFS should initialize mounted target filesystems lazily
Date Fri, 04 Sep 2020 09:20:15 GMT

abhishekdas99 commented on pull request #2260:
URL: https://github.com/apache/hadoop/pull/2260#issuecomment-687031356


   > I like the lazy eval style
   > 
   > * thread safety: what is the story here?
   > * what's the story w.r.t IOExceptions being raised in the init function?
   > 
   > in org.apache.hadoop.fs.impl.FunctionsRaisingIOE we have an interface for functions
which explicilty raise them. Using that or something like it makes sense here
   
   Thanks @steveloughran for the review. 
   I have incorporated FunctionsRaisingIOE to take care of IOException. Thanks for the pointer.
Also added synchronized block around initialization of file system instance.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message