hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] sunchao commented on a change in pull request #2240: HADOOP-17165. Implement service-user feature in DecayRPCScheduler.
Date Wed, 02 Sep 2020 18:21:51 GMT

sunchao commented on a change in pull request #2240:
URL: https://github.com/apache/hadoop/pull/2240#discussion_r482275899



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
##########
@@ -483,6 +501,12 @@ private void recomputeScheduleCache() {
 
     for (Map.Entry<Object, List<AtomicLong>> entry : callCosts.entrySet()) {
       Object id = entry.getKey();
+      // The priority for service users is always 0
+      if (isServiceUser((String)id)) {

Review comment:
       @tasanuma curious why you choose to do it here and `cachedOrComputedPriorityLevel`
instead of `getPriorityLevel` in the previous patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message