hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] jiwq commented on a change in pull request #2028: MAPREDUCE-7279. Adds RM host name to history server web page
Date Tue, 01 Sep 2020 15:50:14 GMT

jiwq commented on a change in pull request #2028:
URL: https://github.com/apache/hadoop/pull/2028#discussion_r481244866



##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
##########
@@ -1588,6 +1588,19 @@ public void stop() {
       this.jobIndexInfo =
           new JobIndexInfo(-1, -1, user, jobName, jobId, -1, -1, null,
                            queueName);
+
+      if (getConfig().getBoolean(
+          JHAdminConfig.MR_HISTORY_APPEND_RM_HOST_TO_HISTORY_FILE_NAME_ENABLED,
+          JHAdminConfig.DEFAULT_MR_HISTORY_APPEND_RM_HOST_TO_HISTORY_FILE_NAME_ENABLED))
{
+
+        String hostName = getConfig().get(YarnConfiguration.RM_HOSTNAME, "");

Review comment:
       If we don't config the `yarn.resourcemanager.address` in client, how do we get the
right address? And if enabled the federation feature, how can we ensure this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message