hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] liuml07 commented on pull request #2197: HADOOP-17159 Ability for forceful relogin in UserGroupInformation class
Date Wed, 26 Aug 2020 17:24:55 GMT

liuml07 commented on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-681017115


   @sguggilam We both agree on that we need to change all two callsites in UGI. For the new
API, if we keep it as it, is a bit confusing when user calls with `false` value when user
does not need to ignore last login time. In that case, we still ignore the TGT check since
the first parameter is always `false`.
   ```
     public void reloginFromKeytab(boolean ignoreTimeElapsed) throws IOException {
       reloginFromKeytab(false, ignoreTimeElapsed);
     }
   ```
   
   Since the forceful login is the main target, how about we create a new method name, and
use `false` for both parameter?
   ```
   public void forceReloginFromKeytab() throws IOException {
       reloginFromKeytab(false, true);
   }
   ```
   
   I think since this a bug, it's better not to create followup JIRAs but instead create a
new full pull request. So when people backport or check the change for debugging, they do
not need to jump different PRs to understand what's happening as addendum. I will revert the
commit in git repo, and the new PR will be including the full code. How about that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message