hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16126) ipc.Client.stop() may sleep too long to wait for all connections
Date Fri, 01 Mar 2019 09:07:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781483#comment-16781483
] 

Takanobu Asanuma commented on HADOOP-16126:
-------------------------------------------

Thanks for your +1, [~ajisakaa].

Committed to branch-2, branch-2.9 and branch-2.8.

> ipc.Client.stop() may sleep too long to wait for all connections
> ----------------------------------------------------------------
>
>                 Key: HADOOP-16126
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16126
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: c16126_20190219.patch, c16126_20190220.patch, c16126_20190221.patch
>
>
> {code}
> //Client.java
>   public void stop() {
>     ...
>     // wait until all connections are closed
>     while (!connections.isEmpty()) {
>       try {
>         Thread.sleep(100);
>       } catch (InterruptedException e) {
>       }
>     }
>     ...
>   }
> {code}
> In the code above, the sleep time is 100ms.  We found that simply changing the sleep
time to 10ms could improve a Hive job running time by 10x.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message