hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-16019) ZKDelegationTokenSecretManager won't log exception message occured in function setJaasConfiguration
Date Fri, 04 Jan 2019 11:38:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734060#comment-16734060
] 

Steve Loughran commented on HADOOP-16019:
-----------------------------------------

checkstyle is line too long, please break

Given the exception is being logged, no need for the +ex.getMessage() on the string. If you
really want it, I'd prefer ex.toString (not all exceptions have a message, with NPE being
the key example). You can go
{code}
LOG.warn("text {}", e, e) 
{code}
and have the toString invoked only on demand.

> ZKDelegationTokenSecretManager won't log exception message occured in function setJaasConfiguration
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-16019
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16019
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.1.0
>            Reporter: luhuachao
>            Priority: Minor
>         Attachments: HADOOP-16019.1.patch, HADOOP-16019.2.patch
>
>
> * when the config  ZK_DTSM_ZK_KERBEROS_KEYTAB  or ZK_DTSM_ZK_KERBEROS_PRINCIPAL are
not set, the IllegalArgumentException message cannot be logged.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message