From common-issues-return-162475-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Dec 20 17:34:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 14DF5180718 for ; Thu, 20 Dec 2018 17:34:05 +0100 (CET) Received: (qmail 8999 invoked by uid 500); 20 Dec 2018 16:34:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 8789 invoked by uid 99); 20 Dec 2018 16:34:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2018 16:34:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 05290C2389 for ; Thu, 20 Dec 2018 16:34:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.001 X-Spam-Level: X-Spam-Status: No, score=-109.001 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id V5AJkXf4vtoK for ; Thu, 20 Dec 2018 16:34:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D57505F1F3 for ; Thu, 20 Dec 2018 16:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03AF9E0E33 for ; Thu, 20 Dec 2018 16:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4290A23FF9 for ; Thu, 20 Dec 2018 16:34:00 +0000 (UTC) Date: Thu, 20 Dec 2018 16:34:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-16018) DistCp won't reassemble chunks when blocks per chunk > 0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-16018?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 726007#comment-16726007 ]=20 ASF GitHub Bot commented on HADOOP-16018: ----------------------------------------- GitHub user kai33 opened a pull request: https://github.com/apache/hadoop/pull/451 HADOOP-16018: Fix DistCp not reassemble chunks when blocks per chunk > = 0 =20 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kai33/hadoop HADOOP-16018 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/451.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #451 =20 ---- commit 739a1548261e64d333fc42ae58b0ed3021e4c5b7 Author: Kai33 Date: 2018-12-20T16:19:28Z Fix DistCp not reassemble chunks when blocks per chunk > 0 ---- > DistCp won't reassemble chunks when blocks per chunk > 0 > -------------------------------------------------------- > > Key: HADOOP-16018 > URL: https://issues.apache.org/jira/browse/HADOOP-16018 > Project: Hadoop Common > Issue Type: Bug > Components: tools/distcp > Affects Versions: 3.2.0, 2.9.2 > Reporter: Kai X > Priority: Major > > I was investigating why hadoop-distcp-2.9.2 won't=C2=A0reassemble chunks = of the same file when blocks per chunk has been set > 0. > In the CopyCommitter::commitJob,=C2=A0this logic can prevent chunks from = reassembling if blocks per chunk is equal to 0: > {code:java} > if (blocksPerChunk > 0) { > concatFileChunks(conf); > } > {code} > Then in CopyCommitter's ctor, blocksPerChunk is initialised from the conf= ig: > {code:java} > blocksPerChunk =3D context.getConfiguration().getInt( > DistCpOptionSwitch.BLOCKS_PER_CHUNK.getConfigLabel(), 0); > {code} > =C2=A0 > But here the config key=C2=A0DistCpOptionSwitch.BLOCKS_PER_CHUNK.getConfi= gLabel() will always returns empty string because it is constructed without= config label: > {code:java} > BLOCKS_PER_CHUNK("", > new Option("blocksperchunk", true, "If set to a positive value, files" > + "with more blocks than this value will be split into chunks of " > + " blocks to be transferred in parallel, and " > + "reassembled on the destination. By default, is " > + "0 and the files will be transmitted in their entirety without " > + "splitting. This switch is only applicable when the source file " > + "system implements getBlockLocations method and the target file " > + "system implements concat method")) > {code} > As a result=C2=A0it will fall back to the default value 0 for blocksPerCh= unk, and prevent the chunks from reassembling. > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org