hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Da Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15940) ABFS: For HNS account, avoid unnecessary get call when doing Rename
Date Mon, 19 Nov 2018 18:31:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692090#comment-16692090
] 

Da Zhou commented on HADOOP-15940:
----------------------------------

[~tmarquardt], thanks for review.
 Yes, the patch missed the case for FileNotFoundException.

For the behavior of rename dir:
 - HDFS contract [tests |https://github.com/apache/hadoop/blob/a55d6bba71c81c1c4e9d8cd11f55c78f10a548b0/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java#L765]assume
rename a directory onto itself should fail.
 - HDFS [doc |https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/filesystem/filesystem.html#boolean_renamePath_src_Path_d]
said "Renaming a directory onto itself is no-op; return value is not specified.In POSIX the
result is False; in HDFS the result is True."
 - The fix provided by you also return false, because service will return "INVALID_RENAME_SOURCE_PATH"
error code for such case.

Based on the above, do you think we should override the contract test so renameDirToItself
should return *false* for this corner case?

> ABFS: For HNS account, avoid unnecessary get call when doing Rename
> -------------------------------------------------------------------
>
>                 Key: HADOOP-15940
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15940
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.2.0
>            Reporter: Da Zhou
>            Assignee: Da Zhou
>            Priority: Major
>         Attachments: HADOOP-15940-001.patch
>
>
> When rename, there is always a GET dst file status call, this is not necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message