hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kuhu Shukla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15909) KeyProvider class should implement Closeable
Date Wed, 07 Nov 2018 21:40:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678813#comment-16678813

Kuhu Shukla commented on HADOOP-15909:

[~daryn], I have not added a test as it is a simple implements clause change. I can add a
static object type check on what all it implements and such as a test if you think that is
required. Appreciate a review. Thanks a lot!

> KeyProvider class should implement Closeable
> --------------------------------------------
>                 Key: HADOOP-15909
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15909
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>    Affects Versions: 3.0.3, 2.8.5
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>            Priority: Major
>         Attachments: HADOOP-15909.001.patch
> KeyProviders and the extensions have close() methods. The classes should implement Closeable
that will allow try-with-resources to work and help catch original exceptions instead of finally
blocks and exception masking that follows that.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message