hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15870) S3AInputStream.remainingInFile should use nextReadPos
Date Tue, 13 Nov 2018 13:23:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685186#comment-16685186
] 

Steve Loughran commented on HADOOP-15870:
-----------------------------------------

Reviewing patch 001 on HADOOP-15920 Looks like the new test fails on the local tests

* the assert should list the current (failing) value
* we're into the corners of the semantics of "what happens at the EOF". this is a troublespot
as it shows up those places where HDFS and Posix diverge. This also means we'll have to submit
this patch to HDFS too, to get its test coverage. (ideally: run them locally first, so that'll
just be due diligence)

> S3AInputStream.remainingInFile should use nextReadPos
> -----------------------------------------------------
>
>                 Key: HADOOP-15870
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15870
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.8.4, 3.1.1
>            Reporter: Shixiong Zhu
>            Assignee: lqjacklee
>            Priority: Major
>
> Otherwise `remainingInFile` will not change after `seek`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message