hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Surendra Singh Lilhore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15869) BlockDecompressorStream#decompress should not return -1 in case of IOException.
Date Wed, 24 Oct 2018 09:24:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661989#comment-16661989
] 

Surendra Singh Lilhore commented on HADOOP-15869:
-------------------------------------------------

{quote}should we catch the IOException ? 
{quote}
No, we shouldn't catch IOException but in current code it is catching and it is causing data
lose for user.

> BlockDecompressorStream#decompress should not return -1 in case of IOException.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-15869
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15869
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.7.2
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>            Priority: Major
>         Attachments: HADOOP-15869.01.patch
>
>
> BlockDecompressorStream#decompress() return -1 in case of BlockMissingException. Application
which is using BlockDecompressorStream may think file is empty and proceed further. But
actually read operation should fail.
> {code:java}
> // Get original data size
> try {
>    originalBlockSize = rawReadInt();
> } catch (IOException ioe) {
>    return -1;
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message