hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15808) Harden Token service loader use
Date Wed, 03 Oct 2018 14:19:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637017#comment-16637017

Steve Loughran commented on HADOOP-15808:

HADOOP-15808: patch 002: remove state checks for no class found on decode; leave callers to
deal with it. 

That's not ideal, as most of the code doesn't bother to handle decoded token == null, but
its clear that some bits of code does, and is happy for things to return null. Someone would
need to go through every single use of decodeIdentifier and review/patch it, which is beyond
the scope of this patch.

* Improve error text on TestSaslRPC failures (used in tracking down problem)
* fix checkstyle.

> Harden Token service loader use
> -------------------------------
>                 Key: HADOOP-15808
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15808
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.9.1, 3.1.2
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-15808-001.patch, HADOOP-15808-002.patch
> The Hadoop token service loading (identifiers, renewers...) works provided there's no
problems loading any registered implementation. If there's a classloading or classcasting
problem, the exception raised will stop all token support working; possibly the application
not starting.
> This matters for S3A/HADOOP-14556 as things may not load if aws-sdk isn't on the classpath.
It probably lurks in the wasb/abfs support too, but things have worked there because the installations
with DT support there have always had correctly set up classpaths.
> Fix: do what we did for the FS service loader. Catch failures to instantiate a service
provider impl and skip it

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message