hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15785) [JDK10] Javadoc build fails on JDK 10 in hadoop-common
Date Wed, 10 Oct 2018 06:45:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644523#comment-16644523
] 

Takanobu Asanuma commented on HADOOP-15785:
-------------------------------------------

[~dineshchitlangia] I reviewed the whole codes. Almost all of the codes seem good. Thanks
again for your work.

Two minor comments:

*QuotaUsage:*

{code}
/**
 * Output format:
 * <----12----> <----15----> <----15----> <----15----> <-------18------->
 *    QUOTA   REMAINING_QUATA SPACE_QUOTA SPACE_QUOTA_REM FILE_NAME
 */
{code}

This ascii arts is for programmers, so I suggest we leave it as it is. How about using just
comments ( /* ... \*/ ) instead of javadoc ( /** ... \*/ )?

*CBZip2InputStream:*

There is a typo for the escaping word.
{noformat}
*lt;
{noformat}

> [JDK10] Javadoc build fails on JDK 10 in hadoop-common
> ------------------------------------------------------
>
>                 Key: HADOOP-15785
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15785
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, documentation
>            Reporter: Takanobu Asanuma
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: HADOOP-15785.001.patch, HADOOP-15785.002.patch
>
>
> {noformat}
> $ mvn javadoc:javadoc --projects hadoop-common-project/hadoop-common
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 02:22 min
> [INFO] Finished at: 2018-09-25T02:23:06Z
> [INFO] Final Memory: 119M/467M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:jar
(module-javadocs) on project hadoop-common: MavenReportException: Error while generating Javadoc:

> [ERROR] Exit code: 1 - javadoc: warning - You have not specified the version of HTML
to use.
> [ERROR] The default is currently HTML 4.01, but this will change to HTML5
> [ERROR] in a future release. To suppress this warning, please specify the
> [ERROR] version of HTML used in your documentation comments and to be
> [ERROR] generated by this doclet, using the -html4 or -html5 options.
> [ERROR] /hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1578:
error: malformed HTML
> [ERROR] * to servers are uniquely identified by <remoteAddress, protocol, ticket>
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message