hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15717) TGT renewal thread does not log IOException
Date Thu, 11 Oct 2018 21:47:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647068#comment-16647068
] 

Xiao Chen commented on HADOOP-15717:
------------------------------------

Thanks for the discussion [~rkanter] and [~snemeth].

https://www.slf4j.org/apidocs/org/slf4j/Logger.html has a dedicated section for this actually.
:)
{quote}
Be sure to read the FAQ entry relating to parameterized logging. Note that logging statements
can be parameterized in presence of an exception/throwable.
{quote}
which links to https://www.slf4j.org/faq.html#paramException .

I also confirmed with {{TestUGI#testKerberosTicketIsDestroyedChecked}} that the behavior is
the same.

But as the slf4j page explains, this behavior is post slf4j 1.6.0, I think it's probably a
good idea to commit the patch as-is, so we don't change behavior based on slf4j's version.
+1 on patch 2 from me.

> TGT renewal thread does not log IOException
> -------------------------------------------
>
>                 Key: HADOOP-15717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15717
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: HADOOP-15717.001.patch, HADOOP-15717.002.patch
>
>
> I came across a case where tgt.getEndTime() was returned null and it resulted in an NPE,
this observation was popped out of a test suite execution on a cluster. The reason for logging
the {{IOException}} is that it helps to troubleshoot what caused the exception, as it can
come from two different calls from the try-catch.
> I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from logging the
fact that the ticket's {{endDate}} was null, we have not logged the exception at all.
> With the current code, the exception is swallowed and the thread terminates in case the
ticket's {{endDate}} is null. 
> As this can happen with OpenJDK for example, it is required to print the exception (stack
trace, message) to the log.
> The code should be updated here: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message