hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szilard Nemeth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15717) TGT renewal thread does not log IOException
Date Tue, 09 Oct 2018 22:54:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644197#comment-16644197
] 

Szilard Nemeth commented on HADOOP-15717:
-----------------------------------------

Hi [~xiaochen], [~rkanter]!
Oh I see what I had overlooked.
Removed the newly added error log and modified the 2 existing error logs to contain the exception.
Unfortunately, I had to use String.format, as there's no API from this version of log4j that
would support object parameters and exception logging at the same time.
Actually, on line 945, the code's intention was to log the exception, but as the signature
of the log4j API call is different, it was never logged. The call had less format specifiers
in the string, too (4 instead of 5).

> TGT renewal thread does not log IOException
> -------------------------------------------
>
>                 Key: HADOOP-15717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15717
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: HADOOP-15717.001.patch
>
>
> I came across a case where tgt.getEndTime() was returned null and it resulted in an NPE,
this observation was popped out of a test suite execution on a cluster. The reason for logging
the {{IOException}} is that it helps to troubleshoot what caused the exception, as it can
come from two different calls from the try-catch.
> I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from logging the
fact that the ticket's {{endDate}} was null, we have not logged the exception at all.
> With the current code, the exception is swallowed and the thread terminates in case the
ticket's {{endDate}} is null. 
> As this can happen with OpenJDK for example, it is required to print the exception (stack
trace, message) to the log.
> The code should be updated here: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message