hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15726) Create utility to limit frequency of log statements
Date Wed, 19 Sep 2018 21:15:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621221#comment-16621221
] 

Erik Krogen commented on HADOOP-15726:
--------------------------------------

Thanks [~vagarychen]! Can we get this backported to older branches as well? The current patch
applies to {{branch-3.1}} directly, but not to {{branch-3.0}} because {{FSNamesystemLock}}
uses log4j API instead of slf4j. I attached a {{branch-3.0}} patch which also works for {{branch-2}}.

> Create utility to limit frequency of log statements
> ---------------------------------------------------
>
>                 Key: HADOOP-15726
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15726
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common, util
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>             Fix For: 3.2.0
>
>         Attachments: HADOOP-15726.000.patch, HADOOP-15726.001.patch, HADOOP-15726.002.patch,
HADOOP-15726.003.patch, HDFS-15726-branch-3.0.003.patch
>
>
> There is a common pattern of logging a behavior that is normally extraneous. Under some
circumstances, such a behavior becomes common, flooding the logs and making it difficult to
see what else is going on in the system. Under such situations it is beneficial to limit how
frequently the extraneous behavior is logged, while capturing some summary information about
the suppressed log statements.
> This is currently implemented in {{FSNamesystemLock}} (in HDFS-10713). We have additional
use cases for this in HDFS-13791, so this is a good time to create a common utility for different
sites to share this logic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message