hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15723) ABFS: Ranger Support
Date Tue, 18 Sep 2018 13:37:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619117#comment-16619117

Steve Loughran commented on HADOOP-15723:

Patch 003: 
* adds the comments I made about IOEs
* add interface stability comments from HADOOP-15704
* fix javadocs with "." at the end of every javadoc; keeps javadocs happy.
* check for empty path array happens in {{performADLAuthCheck}}, so {{AdlAuthorizer.isAuthorized()}}
will never get a list of size 0.
* and a bit of extra resiliience in generating error exception

Now, the existing javadocs of {{AdlAuthorizer.isAuthorized()}} say "The absolute paths of
the storage being accessed."

But: the paths being passed in are not qualified, therefore this doesn't hold.

_all uses of  {{performADLAuthCheck}} need to pass in the qualified paths, which generally
means pulling up the makeQualified calls before performing the auth checks._

I've not done it in this patch; I'll leave it to the original authors. Again, this is where
some mock implementation could be handy: it could verify that all paths come in as qualified.

> ABFS: Ranger Support
> --------------------
>                 Key: HADOOP-15723
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15723
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Thomas Marquardt
>            Assignee: Da Zhou
>            Priority: Major
>         Attachments: HADOOP-15273-HADOOP-15407-001.patch, HADOOP-15273-HADOOP-15407-002.patch,
> Add support for Ranger

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message