hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szilard Nemeth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15676) Cleanup TestSSLHttpServer
Date Sun, 16 Sep 2018 21:10:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616893#comment-16616893
] 

Szilard Nemeth commented on HADOOP-15676:
-----------------------------------------

Thanks [~xiaochen] for your comments!
Uploaded a new patch that fixes the code duplication.
With the try-catch block with the {{fail\(\)}} call, I haven't modified the original code.
I guess the intention was to not only fail when the {{SSLHandshakeException}} is thrown, the
test should fail and provide a more detailed error message (1st parameter to {{fail\(\)}}.

What idea do you have in mind to fix that?
Thanks!

> Cleanup TestSSLHttpServer
> -------------------------
>
>                 Key: HADOOP-15676
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15676
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 2.6.0
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: HADOOP-15676.001.patch, HADOOP-15676.002.patch, HADOOP-15676.003.patch
>
>
> This issue will fix: 
> * Several typos in this class
> * Code is not very well readable in some of the places.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message