hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15009) hadoop-resourceestimator's shell scripts are a mess
Date Mon, 17 Sep 2018 21:05:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618151#comment-16618151
] 

Subru Krishnan commented on HADOOP-15009:
-----------------------------------------

[~sunilg] when I tried to check the patch, I realized I like the existing script better (semantically)
as the Resource Estimator is independent of YARN. 

Ideally we should have a start/stop daemon for Tools like we have for YARN/HDFS and then move
all tools like Resource Estimator, SLS to it. For now, I have set the priority to Major.

> hadoop-resourceestimator's shell scripts are a mess
> ---------------------------------------------------
>
>                 Key: HADOOP-15009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15009
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts, tools
>    Affects Versions: 3.1.0
>            Reporter: Allen Wittenauer
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HADOOP-15009.001.patch, Screen Shot 2017-12-12 at 11.16.23 AM.png
>
>
> #1:
> There's no reason for estimator.sh to exist.  Just make it a subcommand under yarn or
whatever.  
> #2:
> In it's current form, it's missing a BUNCH of boilerplate that makes certain functionality
completely fail.
> #3
> start/stop-estimator.sh is full of copypasta that doesn't actually do anything/work correctly.
 Additionally, if estimator.sh doesn't exist, neither does this since yarn --daemon start/stop
will do everything as necessary.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message