hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil Govindan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15009) hadoop-resourceestimator's shell scripts are a mess
Date Mon, 10 Sep 2018 04:02:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608690#comment-16608690
] 

Sunil Govindan commented on HADOOP-15009:
-----------------------------------------

[~subru] could u pls help to review thisĀ as we are closing on 3.2.0 code freeze. Thank you.

> hadoop-resourceestimator's shell scripts are a mess
> ---------------------------------------------------
>
>                 Key: HADOOP-15009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15009
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts, tools
>    Affects Versions: 3.1.0
>            Reporter: Allen Wittenauer
>            Assignee: Ajay Kumar
>            Priority: Blocker
>         Attachments: HADOOP-15009.001.patch, Screen Shot 2017-12-12 at 11.16.23 AM.png
>
>
> #1:
> There's no reason for estimator.sh to exist.  Just make it a subcommand under yarn or
whatever.  
> #2:
> In it's current form, it's missing a BUNCH of boilerplate that makes certain functionality
completely fail.
> #3
> start/stop-estimator.sh is full of copypasta that doesn't actually do anything/work correctly.
 Additionally, if estimator.sh doesn't exist, neither does this since yarn --daemon start/stop
will do everything as necessary.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message