hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15674) Test failure TestSSLHttpServer.testExcludedCiphers with TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 cipher suite
Date Wed, 15 Aug 2018 20:25:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581565#comment-16581565
] 

Xiao Chen commented on HADOOP-15674:
------------------------------------

Thanks [~gabor.bota] for filing the jira and [~snemeth] for providing a fix.

Looks good to me overall. Some minor comments:
- log4j's parameterized messages can be used for logging. (See https://logging.apache.org/log4j/2.0/manual/messages.html).
- In Javadoc I'd remove the mention of the jira number. The description seems clear enough,
and one can always git blame to find the jira number if needed.

We generally don't encourage fixing stuff unrelated to the jira to reduce the chance of conflicts.
But since this is a test class and the fix is only 1 typo, I'll let this one slide.

> Test failure TestSSLHttpServer.testExcludedCiphers with TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
cipher suite
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15674
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15674
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 2.6.0
>            Reporter: Gabor Bota
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: HADOOP-15674-branch-2.001.patch, HADOOP-15674-branch-3.0.0.001.patch,
HADOOP-15674.001.patch
>
>
> Running {{hadoop/hadoop-common-project/hadoop-common# mvn test -Dtest="TestSSLHttpServer#testExcludedCiphers"
-Dhttps.protocols=TLSv1.2 -Dhttps.cipherSuites=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256}} fails
with:
> {noformat}
> Error Message
> No Ciphers in common, SSLHandshake must fail.
> Stacktrace
> 	java.lang.AssertionError: No Ciphers in common, SSLHandshake must fail.
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.apache.hadoop.http.TestSSLHttpServer.testExcludedCiphers(TestSSLHttpServer.java:178)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message