hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kitti Nanasi (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-15665) Checkstyle shows false positive report
Date Thu, 09 Aug 2018 20:56:00 GMT
Kitti Nanasi created HADOOP-15665:
-------------------------------------

             Summary: Checkstyle shows false positive report
                 Key: HADOOP-15665
                 URL: https://issues.apache.org/jira/browse/HADOOP-15665
             Project: Hadoop Common
          Issue Type: Bug
          Components: precommit, yetus
    Affects Versions: 3.1.0
            Reporter: Kitti Nanasi


If a patch is created with checkstyle errors, for example when a modified line is longer than
80 characters, then running checkstyle with the test-patch script runs to success (though
it should fail and show an error about the long line).
{code:java}
dev-support/bin/test-patch  --plugins="-checkstyle" test.patch{code}
However it does show the error (so works correctly) when running it with the IDEA checkstyle
plugin.

 

I only tried it out it for patches with too long lines and wrong indentation, but I assume
that it can be a more general problem.

We realised this when reviewing HDFS-13217, where patch 004 has a "too long line" checkstyle
error. In the first build for that patch, the checkstyle report was showing the error, but
when it was ran again with the same patch, the error disappeared. So probably the checkstyle
checking stopped working on trunk somewhere between April and July 2018.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message