hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15637) LocalFs#listLocatedStatus does not filter out hidden .crc files
Date Fri, 27 Jul 2018 18:08:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560086#comment-16560086
] 

Erik Krogen commented on HADOOP-15637:
--------------------------------------

Thanks for the review Chen! I'm a fan of defensive programming but I think in this case, the
{{RemoteIterator#next()}} Javadoc states:
{code}
   * @return the next element in the iteration.
   * @throws NoSuchElementException iteration has no more elements.
{code}
implying that a NSEE should be thrown rather than a null. If an implementation returns {{null}}
as a valid "element in the iteration", that's clearly an underlying bug and I think I would
rather not ignore it (basically, failure promotion rather than masking). Let me know if you
disagree.

> LocalFs#listLocatedStatus does not filter out hidden .crc files
> ---------------------------------------------------------------
>
>                 Key: HADOOP-15637
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15637
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HADOOP-15637.000.patch
>
>
> After HADOOP-7165, {{LocalFs#listLocatedStatus}} incorrectly returns the hidden {{.crc}}
files used to store checksum information. This is because HADOOP-7165 implemented {{listLocatedStatus}}
on {{FilterFs}}, so the default implementation is no longer used, and {{FilterFs}} directly
calls the raw FS since {{listLocatedStatus}} is not defined in {{ChecksumFs}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message