hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Sigelman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15566) Remove HTrace support
Date Tue, 03 Jul 2018 00:43:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530630#comment-16530630
] 

Ben Sigelman commented on HADOOP-15566:
---------------------------------------

The screenshots are really nice to see!

I'm not sure how you all like to work, but I am happy to help discuss how to make all of this
work from an OpenTracing best-practices standpoint (and/or try to find people to help with
the instrumentation or porting effort).

 

There was a question about about Tracer impls:
{quote}I can see people might want an implementation that is more neutral, For example, Jaeger
comes from Uber, and people might not want to use it (hey, any Lyft developers here? :))
{quote}
Typically the idiom is to let the user pass in a `Tracer` impl dynamically, but fall back
on the `GlobalTracer` mechanism if no user-specified `Tracer` was provided. There's also a
contributed (and wholly optional) OpenTracing utility to do `Tracer` injection dynamically
(i.e., with zero code modification): [https://github.com/opentracing-contrib/java-tracerresolver]

 

Also, re wire protocols: OpenTracing is designed to be intentionally agnostic about wire protocols
and abstracts serialization ("injection") and deserialization ("extraction") into the `Tracer`
implementation. If there are questions about best practices around this, please @-mention
me and I'll do my best to help.

 

(Thanks again, all)

> Remove HTrace support
> ---------------------
>
>                 Key: HADOOP-15566
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15566
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.1.0
>            Reporter: Todd Lipcon
>            Priority: Major
>         Attachments: Screen Shot 2018-06-29 at 11.59.16 AM.png, ss-trace-s3a.png
>
>
> The HTrace incubator project has voted to retire itself and won't be making further releases.
The Hadoop project currently has various hooks with HTrace. It seems in some cases (eg HDFS-13702)
these hooks have had measurable performance overhead. Given these two factors, I think we
should consider removing the HTrace integration. If there is someone willing to do the work,
replacing it with OpenTracing might be a better choice since there is an active community.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message