hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15546) ABFS: tune imports & javadocs; stabilise tests
Date Sat, 14 Jul 2018 17:01:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544268#comment-16544268
] 

Steve Loughran commented on HADOOP-15546:
-----------------------------------------

Test failure was about from the append test I'd pulled up into common; either test is wrong
or failure not quite as expected
{code}
[ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.735 s <<<
FAILURE! - in org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
[ERROR] testAppendDirectory(org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractAppend)
 Time elapsed: 0.017 s  <<< ERROR!
java.io.IOException: Cannot append to a diretory (=file:/testptch/hadoop/hadoop-common-project/hadoop-common/target/test/data/3/ftiIMjcjYy/test/target
)
	at org.apache.hadoop.fs.RawLocalFileSystem.append(RawLocalFileSystem.java:281)
	at org.apache.hadoop.fs.FileSystem.append(FileSystem.java:1430)
	at org.apache.hadoop.fs.contract.AbstractContractAppendTest.lambda$testAppendDirectory$3(AbstractContractAppendTest.java:164)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:491)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:377)
	at org.apache.hadoop.fs.contract.AbstractContractAppendTest.testAppendDirectory(AbstractContractAppendTest.java:163)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{code}

> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>
>                 Key: HADOOP-15546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-15546-001.patch, HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch, HADOOP-15546-HADOOP-15407-005.patch
>
>
> Followup on HADOOP-15540 with some initial review tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some commitment
to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml
for all to use
> * other IDE-suggested tweaks
> No actual code changes here; just setting things up better for >1 person editing &
testing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message