hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Mackrory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15546) ABFS: tune imports & javadocs; stabilise tests
Date Fri, 20 Jul 2018 16:22:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550941#comment-16550941
] 

Sean Mackrory commented on HADOOP-15546:
----------------------------------------

Had to change uses of touch(FileSystem, Path) to touch(Path), fyi. Other changes look good.
Hoping to dig into this today, but with my config that's virtually identical to what mostly
works without this patch, every single ABFS integration test fails for me with one of the
following after applying this patch (and I have moved it from azure-bfs-auth-keys.xml to azure-auth-keys.xml):

{code}
Caused by: com.microsoft.azure.storage.StorageException: Value for one of the query parameters
specified in the request URI is invalid.
Caused by: com.microsoft.azure.storage.StorageException: Server failed to authenticate the
request. Make sure the value of Authorization header is formed correctly including the signature.
{code}

It's mostly the former. Attaching a sanitized copy of my config in case you happen to spot
something that's obviously wrong or that has changed before I do.

> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>
>                 Key: HADOOP-15546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-15546-001.patch, HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch, HADOOP-15546-HADOOP-15407-005.patch,
HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-007.patch,
HADOOP-15546-HADOOP-15407-008.patch, azure-auth-keys.xml
>
>
> Followup on HADOOP-15540 with some initial review tuning
> h2. Tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some commitment
to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml
for all to use
> * other IDE-suggested tweaks
> h2. Testing
> Review the tests, move to ContractTestUtil assertions, make more consistent to contract
test setup, and general work to make the tests work well over slower links, document, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message