hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-15546) ABFS: tune imports & javadocs; stabilise tests
Date Wed, 18 Jul 2018 23:04:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548549#comment-16548549
] 

Steve Loughran edited comment on HADOOP-15546 at 7/18/18 11:03 PM:
-------------------------------------------------------------------

HADOOP-15546 patch 007

more test code review;
* moving stream reads/writes into try-with-resources
* assertEquals order
* messages on assert failures
* clean up unused imports
* ITestAzureBlobFileSystemRandomRead tagged as scale test
* Address Sean Macrory's comment about errors in testing doca

I am seeing {{ITestAbfsFileSystemContractRename}} fail repeatedly with timeouts and errors.
That is: rename() doesn't appear to be working.

would be good to know what others see


was (Author: stevel@apache.org):
HADOOP-15446 patch 007

more test code review;
* moving stream reads/writes into try-with-resources
* assertEquals order
* messages on assert failures
* clean up unused imports
* ITestAzureBlobFileSystemRandomRead tagged as scale test
* Address Sean Macrory's comment about errors in testing doca

I am seeing {{ITestAbfsFileSystemContractRename}} fail repeatedly with timeouts and errors.
That is: rename() doesn't appear to be working.

would be good to know what others see

> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>
>                 Key: HADOOP-15546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-15546-001.patch, HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch, HADOOP-15546-HADOOP-15407-005.patch,
HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-007.patch
>
>
> Followup on HADOOP-15540 with some initial review tuning
> h2. Tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some commitment
to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml
for all to use
> * other IDE-suggested tweaks
> h2. Testing
> Review the tests, move to ContractTestUtil assertions, make more consistent to contract
test setup, and general work to make the tests work well over slower links, document, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message