hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15409) S3AFileSystem.verifyBucketExists to move to s3.doesBucketExistV2
Date Fri, 27 Jul 2018 21:36:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560360#comment-16560360
] 

ASF GitHub Bot commented on HADOOP-15409:
-----------------------------------------

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/367#discussion_r205905291
  
    --- Diff: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABlocksize.java
---
    @@ -80,4 +82,14 @@ public void testRootFileStatusHasBlocksize() throws Throwable {
             status.getBlockSize() >= 0);
       }
     
    +  @Test
    +  public void testVerifyBucketExists() {
    +    S3AFileSystem fs = getFileSystem();
    +    try {
    +      fs.verifyBucketExists();
    +    } catch (IOException e) {
    +      fail(e.getMessage());
    --- End diff --
    
    Given we actually call verifyBucketExists in the initialize() routine, it'll have already
been tested in setup. I think we can get by without adding a new test here.


> S3AFileSystem.verifyBucketExists to move to s3.doesBucketExistV2
> ----------------------------------------------------------------
>
>                 Key: HADOOP-15409
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15409
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.1.0
>            Reporter: Steve Loughran
>            Priority: Blocker
>
> in S3AFileSystem.initialize(), we check for the bucket existing with verifyBucketExists(),
which calls s3.doesBucketExist(). But that doesn't check for auth issues. 
> s3. doesBucketExistV2() does at least validate credentials, and should be switched to.
This will help things fail faster 
> See SPARK-24000



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message