hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15528) Deprecate ContainerLaunch#link by using FileUtil#SymLink
Date Wed, 13 Jun 2018 00:14:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510432#comment-16510432
] 

Íñigo Goiri commented on HADOOP-15528:
--------------------------------------

Thanks [~giovanni.fumarola] for [^HADOOP-15528-HADOOP-15461.v2.patch].
Let's focus to the scope of the scope and do the following:
* Keep a writeLaunchEnv with the old parameters and passing null. This will reduce the number
of calls where we have to add null manually.
* Don't remove the supresswarnings, do a separate JIRA for that; we can commit that to trunk.
* Don't remove link just mark it as deprecate.
* Remove putEnvIfNotNull and putEnvIfNotNull in the new JIRA for trunk.
* Avoid the stetic fixes to parts that are not changed (e.g., TestContainerLaunch #200)
* Avoid fixes to close and supresswarning and jarFile.close().
* Don't remove the testWindowsShellScriptBuilderLink.

> Deprecate ContainerLaunch#link by using FileUtil#SymLink
> --------------------------------------------------------
>
>                 Key: HADOOP-15528
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15528
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Major
>         Attachments: HADOOP-15528-HADOOP-15461.v1.patch, HADOOP-15528-HADOOP-15461.v2.patch
>
>
> {{ContainerLaunch}} currently uses its own utility to create links (including winutils).
> This should be deprecated and rely on {{FileUtil#SymLink}} which is already multi-platform
and pure Java.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message