hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Giovanni Matteo Fumarola (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
Date Fri, 29 Jun 2018 21:50:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528294#comment-16528294
] 

Giovanni Matteo Fumarola commented on HADOOP-14624:
---------------------------------------------------

Thanks [~iapicker] for the work. I think there is an issue with \{{GenericTestUtils}}. Seems
weird to me that you need to define {{private final org.slf4j.Logger LOG;}}.

Can you double check the imports?

NIT: Thanks for cleaning up the code from the whitespaces. However, I would do that in a different
patch to avoid future merge conflicts. Please be stick with the purpose of the jira.

> Add GenericTestUtils.DelayAnswer that accept slf4j logger API
> -------------------------------------------------------------
>
>                 Key: HADOOP-14624
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14624
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Wenxin He
>            Assignee: Wenxin He
>            Priority: Major
>         Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch, HADOOP-14624.003.patch,
HADOOP-14624.004.patch, HADOOP-14624.005.patch, HADOOP-14624.006.patch, HADOOP-14624.007.patch,
HADOOP-14624.008.patch
>
>
> Split from HADOOP-14539.
> Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now we are
migrating the APIs to slf4j, slf4j logger API should be accepted as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message