From common-issues-return-152493-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue May 15 10:33:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E8FB818076D for ; Tue, 15 May 2018 10:33:04 +0200 (CEST) Received: (qmail 9833 invoked by uid 500); 15 May 2018 08:33:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 9536 invoked by uid 99); 15 May 2018 08:33:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 May 2018 08:33:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 28A301807D8 for ; Tue, 15 May 2018 08:33:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SxJQ6gAsnabA for ; Tue, 15 May 2018 08:33:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3FD425F5DF for ; Tue, 15 May 2018 08:33:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3E855E0F80 for ; Tue, 15 May 2018 08:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 77168217A9 for ; Tue, 15 May 2018 08:33:00 +0000 (UTC) Date: Tue, 15 May 2018 08:33:00 +0000 (UTC) From: "Zsolt Venczel (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-15154) Abstract new method assertCapability for StreamCapabilities testing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsolt Venczel updated HADOOP-15154: ----------------------------------- Status: Patch Available (was: Open) > Abstract new method assertCapability for StreamCapabilities testing > ------------------------------------------------------------------- > > Key: HADOOP-15154 > URL: https://issues.apache.org/jira/browse/HADOOP-15154 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Reporter: Xiao Chen > Assignee: Zsolt Venczel > Priority: Minor > Attachments: HADOOP-15154.01.patch > > > From Steve's [comment|https://issues.apache.org/jira/browse/HADOOP-15149?focusedCommentId=16306806&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16306806]: > bq. it'd have been cleaner for the asserts to have been one in a assertCapability(key, StreamCapabilities subject, bool outcome) and had it throw meaningful exceptions on a failure > We can consider abstract such a method to a test util class and use it for all {{StreamCapabilities}} tests as needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org