hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Giovanni Matteo Fumarola (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-15465) Use native java code for symlinks
Date Mon, 14 May 2018 23:20:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475032#comment-16475032
] 

Giovanni Matteo Fumarola commented on HADOOP-15465:
---------------------------------------------------

Attached [^HADOOP-15465.v0.patch].

Few comments about this patch:
 * The current unit tests analyzed \{{FileUtil#symLink}} as a black box. Those run successfully
in Linux and Windows.
 * The code run without any problem in Windows and seems to work in a Linux as well.
 * {\{File.createSymbolicLink}} can throw {{UnsupportedOperationException}} and {{FileAlreadyExistsException}}.
The previous code did not take care of those scenarios.
 * One of the deprecated constructors in \{{MiniYarnCluster}} uses {{Shell#getSymlinkCommand}}.
We should remove it.

 

Thoughts?

> Use native java code for symlinks
> ---------------------------------
>
>                 Key: HADOOP-15465
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15465
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Major
>         Attachments: HADOOP-15465.v0.patch
>
>
> Hadoop uses the shell to create symbolic links. Now that Hadoop relies on Java 7+, we
can deprecate all the shell code and rely on the Java APIs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message